Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add year to log line #139

Closed
kgreenek opened this issue May 11, 2020 · 2 comments
Closed

Add year to log line #139

kgreenek opened this issue May 11, 2020 · 2 comments

Comments

@kgreenek
Copy link

kgreenek commented May 11, 2020

glog recently added the year to the log line. I think abeil-py should too for compatibility. It's also useful to have the year, and only adds 4 characters.

This log line:

I0308 23:47:32.089828 400441 config.cc:27] Some log message

Would change to this:

I20200308 23:47:32.089828 400441 config.cc:27] Some log message

Issue:
google/glog#516

PR:
google/glog#530

@gpshead
Copy link
Contributor

gpshead commented May 11, 2020

We're unlikely to do this. That google/glog project is mostly unrelated to our actual internal C++ logging library other than being derived from a very old version of it and thus having a mostly compatible C++ API.

abseil-cpp may gain a logging library in the future; we aim keep abseil-py in sync with the internal logging library behavior and anything abseil-cpp does.

Changing the log line format is unlikely for compatibility reasons.

@gpshead gpshead closed this as completed May 11, 2020
@kgreenek
Copy link
Author

+1 for abeil-cpp open-sourcing the logging library.

Now it looks like our c++ glog logs will be different from our python absl-py logs if we update glog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants