Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issues with shared libraries #451

Closed
abumq opened this issue Jan 7, 2017 · 6 comments
Closed

Fix the issues with shared libraries #451

abumq opened this issue Jan 7, 2017 · 6 comments

Comments

@abumq
Copy link
Owner

abumq commented Jan 7, 2017

Currently when easylogging++ is used in shared libraries as well as the application linked to that shared libararies, it's pain to get it all working. We need to fix this as this is common design with large C++ applications.

NOTE: We will wait until #445 is finished so we can re-think design slightly

@abumq abumq added the bug label Jan 7, 2017
@abumq abumq added this to the v9.90 milestone Jan 8, 2017
@aparajita
Copy link
Contributor

I have static and shared libs working fine on macOS with Xcode. I'll push the projects sometime this week.

@abumq
Copy link
Owner Author

abumq commented Jan 10, 2017

On XCode, it works for me too but when I used Qt Creator IDE or built it using cmake (on terminal) on thesame system it was crashing.

@aparajita
Copy link
Contributor

Compile in Xcode and then copy the compile and link transcripts. There must be some configuration option Xcode is passing to clang/ld that the others are not.

@abumq
Copy link
Owner Author

abumq commented Jan 10, 2017

Static lib is still problem but shared is working fine

See samples/stl/static-shared-lib

@abumq
Copy link
Owner Author

abumq commented Jan 10, 2017

This is after #445 (issue with static)

@easylogging easylogging removed this from the v9.90 milestone Jan 11, 2017
@easylogging easylogging added need-info and removed bug labels Jan 11, 2017
@abumq
Copy link
Owner Author

abumq commented Jan 15, 2017

It looks all good to me now. It's matter of compiling it right.

@abumq abumq closed this as completed Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants