Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept notification webhook configs as CLI args #1042

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

nasir-rabbani
Copy link
Contributor

These changes will allow us to accept notification web hook config values as CLI args and as form data in Server Mode.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1042 (ad4669b) into master (a3e7161) will increase coverage by 0.24%.
The diff coverage is 93.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   78.32%   78.57%   +0.24%     
==========================================
  Files         238      238              
  Lines        6459     6477      +18     
==========================================
+ Hits         5059     5089      +30     
+ Misses       1091     1075      -16     
- Partials      309      313       +4     
Impacted Files Coverage Δ
pkg/http-server/webhook-scan-logs.go 0.00% <0.00%> (ø)
pkg/runtime/notifications.go 100.00% <ø> (ø)
pkg/http-server/file-scan.go 83.03% <75.00%> (+0.30%) ⬆️
pkg/k8s/admission-webhook/validating-webhook.go 83.67% <83.33%> (+0.22%) ⬆️
pkg/cli/run.go 87.65% <100.00%> (ø)
pkg/cli/scan.go 73.33% <100.00%> (+1.90%) ⬆️
pkg/http-server/remote-repo.go 71.01% <100.00%> (ø)
pkg/http-server/webhook-scan.go 72.72% <100.00%> (+1.99%) ⬆️
pkg/runtime/executor.go 90.90% <100.00%> (+0.56%) ⬆️
pkg/notifications/webhook/webhook.go 52.00% <0.00%> (+16.00%) ⬆️
... and 1 more

@nasir-rabbani nasir-rabbani marked this pull request as ready for review October 7, 2021 08:55
@cesar-rodriguez cesar-rodriguez changed the title accept notification webhook configs as CLI args Accept notification webhook configs as CLI args Oct 11, 2021
@kanchwala-yusuf
Copy link
Contributor

Hey @nasir-rabbani , would it be possible to add e2e or integration test for this feature?

pkg/cli/scan.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cesar-rodriguez cesar-rodriguez merged commit 4ee5e04 into tenable:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants