Add support for repo-url and branch name in CLI flags and scan output #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasir-rabbani
requested review from
patilpankaj212,
kanchwala-yusuf and
Rchanger
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 78.56% 78.62% +0.05%
==========================================
Files 238 238
Lines 6476 6494 +18
==========================================
+ Hits 5088 5106 +18
Misses 1075 1075
Partials 313 313
|
kanchwala-yusuf
suggested changes
Oct 14, 2021
| @@ -108,6 +108,9 @@ type ScanOptions struct { | |||
|
|
|||
| // notificationWebhookToken is the auth token to call the notification webhook URL | |||
| notificationWebhookToken string | |||
|
|
|||
| // repoURL lets us specify URL of the repository being scanned (targetted for pipeline scanning) | |||
| repoURL string | |||
There was a problem hiding this comment.
Please evaluate how the branch information can be captured along with repo url
|
@cesar-rodriguez , should we also capture branch info to uniquely identify the repository branch? |
Yes |
nasir-rabbani
force-pushed
the
repo-url-arg
branch
2 times, most recently
from
57c59ec
to
776a1ab
Compare
nasir-rabbani
force-pushed
the
repo-url-arg
branch
from
776a1ab
to
b22af5d
Compare
cesar-rodriguez
changed the title
cesar-rodriguez
previously approved these changes
Oct 21, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes enable terrascan to accept the url of repository being scanned and reflects the url in the scan summary.