Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ec2 cog lambda acm cft #1129

Merged

Conversation

gaurav-gogia
Copy link
Contributor

Add support for following resources:

  1. aws_instance
  2. aws_network_interface
  3. aws_lambda_function
  4. aws_cognito_user_pool
  5. aws_acm_certificate

Updated signature of function mapConfigForResource to account for edge cases where resources may require their names to generate IDs while generating configurations

- ec2 instance
- cognito user pool
- lambda function
- acm certificate
1. acm certificate
2. cognito user pool
3. instance, network interface
4. lambda function
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1129 (2245d21) into master (ae4eccb) will increase coverage by 0.31%.
The diff coverage is 96.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
+ Coverage   78.77%   79.09%   +0.31%     
==========================================
  Files         244      248       +4     
  Lines        6800     6907     +107     
==========================================
+ Hits         5357     5463     +106     
  Misses       1113     1113              
- Partials      330      331       +1     
Impacted Files Coverage Δ
...ers/cft/config/autoscaling-launch-configuration.go 85.71% <ø> (ø)
...apper/iac-providers/cft/config/sns-topic-policy.go 100.00% <ø> (ø)
pkg/mapper/iac-providers/cft/config/sns-topic.go 100.00% <ø> (ø)
...kg/mapper/iac-providers/cft/config/ec2-instance.go 90.00% <90.00%> (ø)
pkg/mapper/iac-providers/cft/cft.go 95.58% <100.00%> (+0.27%) ⬆️
...iders/cft/config/certificatemanager-certificate.go 100.00% <100.00%> (ø)
...pper/iac-providers/cft/config/cognito-user-pool.go 100.00% <100.00%> (ø)
...mapper/iac-providers/cft/config/lambda-function.go 100.00% <100.00%> (ø)
pkg/iac-providers/cft/v1/sanitize-cft-template.go 83.65% <0.00%> (+1.44%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patilpankaj212 patilpankaj212 merged commit 14a634b into tenable:master Jan 31, 2022
@gaurav-gogia gaurav-gogia deleted the feature/ec2_cog_lambda_acm_cft branch February 4, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants