Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lambda function mapper #1199

Merged
merged 8 commits into from
Mar 30, 2022
Merged

update lambda function mapper #1199

merged 8 commits into from
Mar 30, 2022

Conversation

gaurav-gogia
Copy link
Contributor

@gaurav-gogia gaurav-gogia commented Mar 24, 2022 •
edited
Loading

  • improve lambda function mapper
  • add support for AWS::Serverless::Function
  • remove mapping for filename field
  • remove source code hash field

@gaurav-gogia gaurav-gogia requested a review from a team as a code owner March 24, 2022 20:41
@gaurav-gogia gaurav-gogia self-assigned this Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #1199 (07b65f1) into master (cc59c89) will increase coverage by 0.00%.
The diff coverage is 84.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   78.39%   78.39%           
=======================================
  Files         271      271           
  Lines        7455     7509   +54     
=======================================
+ Hits         5844     5887   +43     
- Misses       1278     1287    +9     
- Partials      333      335    +2
Impacted Files Coverage Δ
...mapper/iac-providers/cft/config/lambda-function.go 86.90% <84.28%> (-13.10%) ⬇️
pkg/mapper/iac-providers/cft/cft.go 89.13% <100.00%> (+0.11%) ⬆️

@gaurav-gogia gaurav-gogia changed the title add setCodePackage function update lambda function mapper Mar 24, 2022
@gaurav-gogia gaurav-gogia added the go Pull requests that update Go code label Mar 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

patilpankaj212
patilpankaj212 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@patilpankaj212 patilpankaj212 merged commit f8c0343 into tenable:master Mar 30, 2022
@gaurav-gogia gaurav-gogia deleted the bugfix/cft-tf-discrepency branch March 31, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patilpankaj212 patilpankaj212 patilpankaj212 approved these changes

Assignees

@gaurav-gogia gaurav-gogia

Labels
bug go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaurav-gogia @patilpankaj212