Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for remote Terraform modules and scanning remotely for other IaC tools #345

Merged
merged 32 commits into from
Oct 5, 2020

Conversation

kanchwala-yusuf
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf commented Sep 30, 2020

Adding support for downloading remote modules in:

  • CLI
  • API server
  • Terraform IaC scanning

Closes #2

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #345 into master will increase coverage by 1.73%.
The diff coverage is 76.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   62.05%   63.78%   +1.73%     
==========================================
  Files          61       66       +5     
  Lines        1215     1378     +163     
==========================================
+ Hits          754      879     +125     
- Misses        391      419      +28     
- Partials       70       80      +10     
Impacted Files Coverage Δ
pkg/cli/scan.go 34.28% <50.00%> (+3.03%) ⬆️
pkg/iac-providers/terraform/v12/load-dir.go 80.85% <61.53%> (-3.36%) ⬇️
pkg/http-server/remote-repo.go 62.96% <62.96%> (ø)
pkg/cli/run.go 42.30% <64.28%> (+8.97%) ⬆️
pkg/downloader/getter.go 82.69% <82.69%> (ø)
pkg/downloader/interface.go 100.00% <100.00%> (ø)
pkg/http-server/routes.go 100.00% <100.00%> (ø)
pkg/iac-providers/terraform/v12/module-download.go 100.00% <100.00%> (ø)
pkg/utils/random_string.go 100.00% <100.00%> (ø)
... and 5 more

@kanchwala-yusuf kanchwala-yusuf marked this pull request as ready for review October 1, 2020 07:19
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.0% 3.0% Duplication

@cesar-rodriguez cesar-rodriguez changed the title Feature/downloader support Adds support for remote Terraform modules and scanning remotely for other IaC tools Oct 5, 2020
@cesar-rodriguez cesar-rodriguez merged commit f1c80fe into master Oct 5, 2020
@cesar-rodriguez cesar-rodriguez deleted the feature/downloader-support branch October 5, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support from modules
2 participants