Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git binary to terrascan docker image, required by downloader #360

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add git binary to terrascan docker image, required by downloader #360

merged 1 commit into from
Oct 22, 2020

Conversation

kanchwala-yusuf
Copy link
Contributor

@kanchwala-yusuf kanchwala-yusuf commented Oct 22, 2020 •
edited by cesar-rodriguez
Loading

Closes #349

@kanchwala-yusuf kanchwala-yusuf self-assigned this Oct 22, 2020
@kanchwala-yusuf kanchwala-yusuf removed their assignment Oct 22, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   63.78%   63.78%           
=======================================
  Files          66       66           
  Lines        1378     1378           
=======================================
  Hits          879      879           
  Misses        419      419           
  Partials       80       80

@cesar-rodriguez cesar-rodriguez changed the title add git binary to terrascan docker image, required by downloader Add git binary to terrascan docker image, required by downloader Oct 22, 2020
@cesar-rodriguez cesar-rodriguez merged commit fd2bf7c into master Oct 22, 2020
@cesar-rodriguez cesar-rodriguez deleted the bugfix/add-git-binary branch October 22, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesar-rodriguez cesar-rodriguez cesar-rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'git' to container image, or run container as 'root' user by default
2 participants
@kanchwala-yusuf @cesar-rodriguez