Address #365 by properly handling submodule path #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 62.53% 63.50% +0.96%
==========================================
Files 76 76
Lines 1679 1677 -2
==========================================
+ Hits 1050 1065 +15
+ Misses 539 520 -19
- Partials 90 92 +2
|
cesar-rodriguez
changed the title
kanchwala-yusuf
approved these changes
Nov 6, 2020
salexpdx
reviewed
Nov 6, 2020
| pathArr := strings.Split(req.Path.String(), ".") | ||
| pathArr = pathArr[:len(pathArr)-1] | ||
| pathToModule = filepath.Join(absRootDir, filepath.Join(pathArr...), req.SourceAddr) | ||
| pathToModule = filepath.Join(absRootDir, req.Parent.SourceAddr, req.SourceAddr) |
There was a problem hiding this comment.
I'm concerned that this only moves the issue one level deeper. If you go back to salexpdx@89b06f6#diff-ed0a902412e1c2c9cca7b9c8d22f14edcd3711f1535d0bc128e801e3ac300c84R95, you can see that i looped through. That is done so that if there is more than one layer of sub-modules, it will parse through all the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #365 by properly handling sub-module path.