Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #405 #517

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fixes #405 #517

merged 1 commit into from
Jan 28, 2021

Conversation

gaurav-gogia
Copy link
Contributor

@gaurav-gogia gaurav-gogia commented Jan 28, 2021

fixes #405

now using contains function to check for access_type instead of an exact match to avoid false positives

terrascan generates value of access_type in this format: ${private}

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #517 (4eb3d33) into master (62069cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   75.57%   75.57%           
=======================================
  Files          94       94           
  Lines        2227     2227           
=======================================
  Hits         1683     1683           
  Misses        401      401           
  Partials      143      143           

@cesar-rodriguez cesar-rodriguez merged commit 47d55e0 into tenable:master Jan 28, 2021
@gaurav-gogia gaurav-gogia deleted the fix_405 branch January 29, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants