fix: added validation for module local source dir #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
==========================================
+ Coverage 74.75% 74.87% +0.11%
==========================================
Files 111 111
Lines 3324 3339 +15
==========================================
+ Hits 2485 2500 +15
Misses 654 654
Partials 185 185
|
kanchwala-yusuf
previously approved these changes
May 19, 2021
Comment on lines
322
to
324
| var pathToModule string | ||
| var err error | ||
| var moduleDirDiags hcl.Diagnostics |
There was a problem hiding this comment.
These can go in a single var block, just makes the code tidier
There was a problem hiding this comment.
I'll make this change .
| @@ -321,6 +321,7 @@ func (t TerraformDirectoryLoader) buildUnifiedConfig(rootMod *hclConfigs.Module, | |||
| // figure out path sub module directory, if it's remote then download it locally | |||
| var pathToModule string | |||
| var err error | |||
| var moduleDirDiags hcl.Diagnostics | |||
| if downloader.IsLocalSourceAddr(req.SourceAddr) { | |||
There was a problem hiding this comment.
Wondering, if it is time to get rid of this if-else ladder and move to a switch case?
patilpankaj212
previously approved these changes
May 19, 2021
Rchanger
dismissed stale reviews from patilpankaj212 and kanchwala-yusuf
via
833ac05
patilpankaj212
suggested changes
May 19, 2021
| @@ -344,6 +347,15 @@ func (t TerraformDirectoryLoader) buildUnifiedConfig(rootMod *hclConfigs.Module, | |||
| } | |||
| } | |||
|
|
|||
| // verify whether the module source directory has any .tf config files | |||
| if !t.parser.IsConfigDir(pathToModule) { | |||
There was a problem hiding this comment.
we should modify this check because this will also modify the error message for non existing directories.
|
Kudos, SonarCloud Quality Gate passed!
|
patilpankaj212
approved these changes
May 20, 2021
kanchwala-yusuf
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#782
Fix: Added check for the module source local directory.