Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes k8s policy filtering #963

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Fixes k8s policy filtering #963

merged 1 commit into from
Aug 6, 2021

Conversation

patilpankaj212
Copy link
Contributor

@patilpankaj212 patilpankaj212 commented Aug 5, 2021 •
edited by cesar-rodriguez
Loading

Closes #946

@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #963 (74a38d1) into master (11db729) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   79.10%   78.94%   -0.16%     
==========================================
  Files         220      221       +1     
  Lines        5359     5415      +56     
==========================================
+ Hits         4239     4275      +36     
- Misses        866      880      +14     
- Partials      254      260       +6
Impacted Files Coverage Δ
pkg/filters/filter-specs.go 87.87% <100.00%> (+0.78%) ⬆️
pkg/iac-providers/terraform/commons/load-dir.go 78.50% <0.00%> (-6.21%) ⬇️
pkg/cli/run.go 88.88% <0.00%> (ø)
pkg/iac-providers/terraform/v15/load-dir.go 100.00% <0.00%> (ø)
pkg/policy/docker.go 100.00% <0.00%> (ø)
pkg/runtime/executor.go 89.14% <0.00%> (+0.71%) ⬆️
pkg/cli/scan.go 70.37% <0.00%> (+1.13%) ⬆️

@patilpankaj212 patilpankaj212 linked an issue Aug 5, 2021 that may be closed by this pull request
Helm chart scans use only 4 policies #946
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cesar-rodriguez cesar-rodriguez changed the title temporary fix for k8s policy filtering issue Fixes k8s policy filtering Aug 6, 2021
@cesar-rodriguez cesar-rodriguez merged commit a3e0b6e into tenable:master Aug 6, 2021
@patilpankaj212 patilpankaj212 deleted the temp-fix-filter branch May 5, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesar-rodriguez cesar-rodriguez cesar-rodriguez approved these changes

@kanchwala-yusuf kanchwala-yusuf Awaiting requested review from kanchwala-yusuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart scans use only 4 policies
2 participants
@patilpankaj212 @cesar-rodriguez