Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamics in RL and Observer Examples is Incorrect #106

Closed
nic-barbara opened this issue Jul 17, 2023 · 0 comments · Fixed by #107
Closed

Dynamics in RL and Observer Examples is Incorrect #106

nic-barbara opened this issue Jul 17, 2023 · 0 comments · Fixed by #107
Assignees
@nic-barbara

Comments

@nic-barbara
Copy link
Member

The box dynamics are currently only valid when velocity is positive. The viscous friction term should be -μ*qdot*abs(qdot) not -μ*qdot^2. This affects the RL and observer example scripts and documentation.
@nic-barbara nic-barbara self-assigned this Jul 17, 2023
@nic-barbara nic-barbara linked a pull request Jul 17, 2023 that will close this issue
Bugfix: box dynamics #107
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nic-barbara nic-barbara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: box dynamics acfr/RobustNeuralNetworks.jl
1 participant
@nic-barbara