Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array mutating problem when calculating inverse of (I + M) #139

Closed
MrstupidJ opened this issue Nov 22, 2023 · 3 comments · Fixed by #140
Closed

Array mutating problem when calculating inverse of (I + M) #139

MrstupidJ opened this issue Nov 22, 2023 · 3 comments · Fixed by #140
Assignees

Comments

@MrstupidJ
Copy link
Contributor

There is an array mutating in $\rho \neq 0$ case. This will not affect constructing a model with the corresponding robust property, however, this will affect learning/training of the model via Zygote.

Shall be fixed ASAP.

@MrstupidJ MrstupidJ self-assigned this Nov 22, 2023
@MrstupidJ
Copy link
Contributor Author

The problem is likely introduced when we calculate D22 (this line) .

Not sure about the fix yet, but we could use general paramterisation for now.

@nic-barbara
Copy link
Member

@MrstupidJ we use the following function to calculate D22:

_D22_pass(M, ρ) = ((I+M) \ I) / ρ

As far as I'm aware that shouldn't be mutating any arrays.

Could you please provide a minimal example reproducing the error to help with debugging?

@MrstupidJ MrstupidJ changed the title Array mutating problem Array mutating problem when calculating inverse of (I + M) Nov 24, 2023
@MrstupidJ
Copy link
Contributor Author

Applied the same fix as here.

@nic-barbara nic-barbara linked a pull request Nov 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants