Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 1/alpha_bar^2 here? #17

Closed
MrstupidJ opened this issue Oct 19, 2022 · 2 comments
Closed

Missing 1/alpha_bar^2 here? #17

MrstupidJ opened this issue Oct 19, 2022 · 2 comments
Assignees
@ruigangwang7

Comments

@MrstupidJ
Copy link
Contributor

https://github.com/acfr/RecurrentEquilibriumNetworks.jl/blob/1a8b161ebfa140196bd33e8c9bd55aa3f03d598a/src/Base/direct_params.jl#L75
@nic-barbara
Copy link
Member

Good pickup. I'll add alpha_bar as a property of the direct params and add it to the initialization as well.

@nic-barbara
Copy link
Member

Actually, does it matter that we don't have alpha_bar in the initialisation for DirectParams? We don't use it for the :random initialisation anyway, and the purpose is just to construct some reasonable H-matrix. When we convert to the explicit form we'll use alpha_bar as usual, so it shouldn't really affect the REN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruigangwang7 ruigangwang7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nic-barbara @MrstupidJ @ruigangwang7