Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge output layer into DirectParams #24

Closed
ruigangwang7 opened this issue Nov 1, 2022 · 2 comments · Fixed by #25
Closed

Merge output layer into DirectParams #24

ruigangwang7 opened this issue Nov 1, 2022 · 2 comments · Fixed by #25
Assignees

Comments

@ruigangwang7
Copy link
Contributor

Hi Nic,

Since the ExplicitParam has already included the output layer, maybe we should merge the output layer param into directparams as well. So it will correspond to the implicit G in the paper. How do you think?

Best
Ray

@nic-barbara nic-barbara self-assigned this Nov 1, 2022
@nic-barbara
Copy link
Member

Hi Ray, I've been thinking about doing this but haven't gotten around to it yet. What was Max's reasoning for keeping them separate in the first place?

I agree that they should be merged, particularly now that we have a D22 term that depends on all the direct parameters.

@ruigangwang7
Copy link
Contributor Author

The possible reasons are as follows: 1) make it close to classic RNN,LSTM, having a separate output layer; 2) at the beginning we choose D22=0, so the output layer is decoupled from internal dynamics; 3) for the observer example we just need the state dynamics.

@nic-barbara nic-barbara linked a pull request Nov 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants