Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch failures should cause composer install to fail #183

Closed
danepowell opened this issue Jun 21, 2016 · 0 comments
Closed

Patch failures should cause composer install to fail #183

danepowell opened this issue Jun 21, 2016 · 0 comments
Assignees

Comments

@danepowell
Copy link
Contributor

danepowell commented Jun 21, 2016

Currently, if a patch cannot be applied during composer install, it spits out a warning and then merrily continues on its way. This makes the patching process very fragile, as our automated tests won't catch failed patches.

There's an upstream issue to address this, but it's not going to be fixed in the current branch of composer-patches: cweagans/composer-patches#40

We can also work around it manually by tweaking our test scripts, which is the better approach in the interim:
cweagans/composer-patches#31
cweagans/composer-patches#46

However we fix it, we should submit an identical solution to Lightning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants