Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessibility support note about aria-busy to all rules with accessibility tree as input aspect #2160

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add accessibility support note about aria-busy to all rules with accessibility tree as input aspect #2160

wants to merge 2 commits into from

Conversation

carlosapaduarte
Copy link
Member

Add accessibility support note about aria-busy to all rules with accessibility tree as input aspect

Closes issue(s):

Need for Call for Review:

This will not require a Call for Review: changes to accessibility support

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@carlosapaduarte carlosapaduarte added the Rule Update Use this label for an existing rule that is being updated label Feb 8, 2024
@carlosapaduarte carlosapaduarte self-assigned this Feb 8, 2024
@giacomo-petri
Copy link
Collaborator

Should we contemplate including it in the rule template as well? Otherwise, there's a chance we might overlook this aspect when creating new rules.

Alternatively, we could explore the option of implementing a script to automatically apply/remove this item (and potentially others in the future) to/from all rules.

Jym77
Jym77 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would be good to auto-inject this kind of things (we had case in the past with an assumption when Language is an input aspect) 🤔

giacomo-petri
giacomo-petri requested changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@giacomo-petri giacomo-petri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I had marked it as "request changes," but I never started the review. Please refer to my previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomo-petri giacomo-petri giacomo-petri requested changes

@Jym77 Jym77 Jym77 approved these changes

@tbostic32 tbostic32 tbostic32 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@carlosapaduarte carlosapaduarte

Labels
reviewers wanted Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should rules have an assumption about aria-busy?
4 participants
@carlosapaduarte @giacomo-petri @Jym77 @tbostic32