Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A only filter #670

Closed
silverwind opened this issue Sep 9, 2023 · 2 comments
Closed

A only filter #670

silverwind opened this issue Sep 9, 2023 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@silverwind
Copy link
Contributor

Description:
Support a syntax to set a label when ALL modified paths are all contained in the array.

skip-changelog:
  - only: [CHANGELOG.md]

Justification:
This is useful in a few rare cases like for example when you have a changelog generator and don't want the changelog modification itself become part of the changelog. I'm sure there are more cases, but it's definitely not a common use case.

Are you willing to submit a PR?
no

@silverwind silverwind added feature request New feature or request to improve the current logic needs triage labels Sep 9, 2023
@MaksimZhukov
Copy link
Contributor

Hello @silverwind!
Thank you for the feature request!

Unfortunately, I don't quite understand how the only filter is supposed to work. Could you please explain its logic in more detail?

Have you seen this feature request. Is this what you are looking for?

@silverwind
Copy link
Contributor Author

Yes it's the same request, sorry for not being clear.

I posted a table of how it should work in #487 (comment).

@silverwind silverwind closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants