Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install on Windows is very slow #240

Closed
2 of 5 tasks
G-Rath opened this issue Jun 24, 2022 · 8 comments · Fixed by #393
Closed
2 of 5 tasks

Install on Windows is very slow #240

G-Rath opened this issue Jun 24, 2022 · 8 comments · Fixed by #393
Assignees
Labels
bug Something isn't working

Comments

@G-Rath
Copy link

G-Rath commented Jun 24, 2022

Description:
Installing Go on Windows seems to consistently take at least 30+ seconds to install, usually 1 minute and sometimes more - it's at least consistently 30 seconds longer than on other OSs (which typically take 10-20 seconds).

This consistently represents ~3/4th of the CI run time for osv-detector - the test suite takes only ~20 seconds (on Windows).

image

image

https://github.com/G-Rath/osv-detector/runs/7033093878?check_suite_focus=true

This one took 3 minutes:

https://github.com/G-Rath/osv-detector/runs/7033278935?check_suite_focus=true

Action version:
v3

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

1.17.9

Repro steps:
https://github.com/G-Rath/osv-detector/blob/main/.github/workflows/checks.yml

https://github.com/G-Rath/osv-detector/actions/workflows/checks.yml
https://github.com/G-Rath/osv-detector/runs/7033093878?check_suite_focus=true
https://github.com/G-Rath/osv-detector/runs/7034205194?check_suite_focus=true
https://github.com/G-Rath/osv-detector/runs/7033293623?check_suite_focus=true
https://github.com/G-Rath/osv-detector/runs/7033278935?check_suite_focus=true

Expected behavior:
The install time to be below 30 seconds on average, ideally never going over a minute.

Actual behavior:
The install time is consistently above 30 seconds, often even above 1 minute and sometimes as long as 3 minutes.

@dmitry-shibanov
Copy link
Contributor

Hello @G-Rath. Thank you for your report. We'll investigate the issue.

@panticmilos
Copy link
Contributor

Hi @G-Rath,

We need to replace extracting method in order to fix this issue. I will let you know when that PR is ready.

@e-korolevskii e-korolevskii self-assigned this Aug 11, 2022
@panticmilos panticmilos removed their assignment Aug 31, 2022
@e-korolevskii e-korolevskii removed their assignment Oct 17, 2022
@ValentinTrinque
Copy link

Is this something that is still planned ?

On one of my setup:

  • Linux takes ~20s
  • MacOS is a bit slower and takes ~1m
  • But Windows takes ~3m20s

Screenshot 2023-04-04 at 12 24 11

Not sure if this can help, the problem has been seen on windows there:

@dmitry-shibanov
Copy link
Contributor

Hello @ValentinTrinque. Thank you for your comment. For now we're investigating the issue.

@KyleSanderson
Copy link

Any update on this very simple issue? All of the time is taken in zstd.

@dsame dsame self-assigned this Jun 7, 2023
@KyleSanderson
Copy link

KyleSanderson commented Jun 9, 2023

@dsame none of those runs are public so I can't see what you've tried unfortunately.

Has anyone looked into the 15 yearold dism? It should give 0 second loading, and an optimized compression format on commit. imagex is older, and while I remember it to be slower, I'm unclear on any optimizations that have happened to this even older technology.

@dsame
Copy link
Contributor

dsame commented Jun 13, 2023

@KyleSanderson i made the repo public, but there's no sense to waste your time looking into it. The problem is confirmed, the fix is suggested and the issue is expected to be solved in the next 4-5 weeks.

@IvanZosimov IvanZosimov linked a pull request Jul 12, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants