Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching Support for GHES #362

Closed
tiwarishub opened this issue Mar 28, 2022 · 4 comments
Closed

Caching Support for GHES #362

tiwarishub opened this issue Mar 28, 2022 · 4 comments
Labels
feature request New feature or request to improve the current logic

Comments

@tiwarishub
Copy link
Contributor

tiwarishub commented Mar 28, 2022 •
edited
Loading

Description:
👋 Team, we have recently added support for caching in GHE (target version 3.5). And we saw setup-python action is also using the Action cache service to cache dependency, based on user input, using the actions/cache package.
As we have added support for caching in GHES 3.5, you can modify this condition to use the new isFeatureAvailable function present in @actions/toolkit 2.0.0 to check the presence of Actions cache service.
You can also refer to this change which we are doing for actions/cache action.
@tiwarishub tiwarishub added feature request New feature or request to improve the current logic needs triage labels Mar 28, 2022
@tiwarishub
Copy link
Contributor Author

tiwarishub commented Mar 28, 2022 •
edited
Loading

As this feature will be required for GHES 3.5 and its feature freeze date is the 5th of April. So we will need to prioritize this so that this change can be completed before the End of this week. This change should be small 🙇

@tiwarishub
Copy link
Contributor Author

@actions/actions-service for visibility

@tiwarishub tiwarishub mentioned this issue Mar 29, 2022
Merged
2 tasks
@tiwarishub
Copy link
Contributor Author

PR is raised for this #363

@marko-zivic-93
Copy link
Contributor

We added caching support for GHES.
Closing the issue thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiwarishub @marko-zivic-93