Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is artifact download url to be expired in 1 minute? #60

Open
jjangga0214 opened this issue Mar 9, 2020 · 3 comments
Open

Why is artifact download url to be expired in 1 minute? #60

jjangga0214 opened this issue Mar 9, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jjangga0214
Copy link

I'm not sure whether this issue is proper to be here. Please let me know where to forward if desired.

The official docs for action api says artifact download URL expires in 1 minute.

Why is there such expiration and even so short?

What if someone needs a fixed, lasting URL without an expiration?

Thanks.

@mk-pmb
Copy link

mk-pmb commented Mar 13, 2020

… or if someone is just on a slow uplink.

@yacaovsnc
Copy link
Contributor

I understand the need for a fixed and lasting URL. Unfortunately we do not support this at the moment, it's because the redirect download URL is considered signed with a HMAC key and it is stateless. The blob storage we use does not have ways to authenticate the GitHub user, so we cannot provide long-lasting URLs that bypass security checks for now. Even if an artifact is public, it's possible that the repo will become private in the future so we still need to check for user permission every time.

@nkalupahana
Copy link

nkalupahana commented May 25, 2021

@yacaovsnc Could the timeout be made slightly longer (say, 5 minutes)? On a slow internet connection with really large artifacts, the link expires before it even goes through. (Good example of this: https://github.com/nkalupahana/ros2-foxy-macos/actions/runs/873341876)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants