Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to HTTP crate v1 #3384

Open
Thomasdezeeuw opened this issue May 31, 2024 · 3 comments · May be fixed by #3443
Open

Updating to HTTP crate v1 #3384

Thomasdezeeuw opened this issue May 31, 2024 · 3 comments · May be fixed by #3443
Labels
A-awc project: awc A-http project: actix-http A-web project: actix-web C-chore Category: chore

Comments

@Thomasdezeeuw
Copy link
Contributor

Apologies if this is not the right way to go about this for this crate.

I'm wondering if it's possible to update actix-http (3.7.0) and actix-router (0.5.3) to use v1 of the http crate as both are still on v0.2.

I don't know if that is considered a breaking change or not though.

@robjtede
Copy link
Member

robjtede commented May 31, 2024

also see discussion in #3208

@robjtede robjtede added A-awc project: awc A-http project: actix-http C-chore Category: chore A-web project: actix-web labels May 31, 2024
@robjtede robjtede added this to the actix-web v5.0 milestone May 31, 2024
@robjtede
Copy link
Member

robjtede commented May 31, 2024

I'm open to the idea of providing the necessary compatibility functions to convert to and from http v1 types behind a crate feature. I think that is the most helpful thing we can do at this stage.

We only use the actual primitives from that crate:

  • StatusCode
  • Method
  • Uri
  • HeaderName
  • HeaderValue

As such, the conversion methods will be extremely trivial (as shown already by @asonix: #3208 (comment)) but good to have nonetheless.

None of the composite types like header maps or request/response structures are used.

@Thomasdezeeuw
Copy link
Contributor Author

For our use case we like to remove http v0.2 entirely, but I understand that will require a breaking change (i.e. won't happen until v5).

@robjtede robjtede linked a pull request Jun 8, 2024 that will close this issue
5 tasks
quasiyoke added a commit to quasiyoke/dav-server-rs that referenced this issue Jun 15, 2024
quasiyoke added a commit to quasiyoke/dav-server-rs that referenced this issue Jun 15, 2024
quasiyoke added a commit to quasiyoke/dav-server-rs that referenced this issue Jun 15, 2024
@robjtede robjtede linked a pull request Aug 15, 2024 that will close this issue
5 tasks
@robjtede robjtede linked a pull request Aug 15, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-awc project: awc A-http project: actix-http A-web project: actix-web C-chore Category: chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants