Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the azuread terraform provider #209

Closed
3 tasks done
adamrushuk opened this issue Aug 26, 2021 · 1 comment
Closed
3 tasks done

Upgrade the azuread terraform provider #209

adamrushuk opened this issue Aug 26, 2021 · 1 comment

Comments

@adamrushuk
Copy link
Owner Author

adamrushuk commented Sep 12, 2021

azuread v2.x upgrade notes

Added Microsoft Graph application perms for terraform sp running pipeline:
Application.ReadWrite.All
Group.ReadWrite.All
User.ReadWrite.All

Changes required

  • changed random_password.argocd.result to azuread_application_password.argocd.value (as AAD generates passwords now)
  • changed azuread_application group_membership_claims value to a list, eg: group_membership_claims = ["All"]
  • added security_enabled = true to azuread_group resources (inc azuread_group data resources)
  • azuread_service_principal now has description and notes attributes to add useful context/info

errors

│ Error: Could not disable OAuth2 Permission Scopes for application with object ID "375ed8fa-e2a6-4544-9478-36fe0ab27a3d"

│ with azuread_application.argocd,
│ on argocd_sso.tf line 15, in resource "azuread_application" "argocd":
│ 15: resource "azuread_application" "argocd" {

│ disabling OAuth2 Permission Scopes for Application with object ID
│ "375ed8fa-e2a6-4544-9478-36fe0ab27a3d":
│ ApplicationsClient.BaseClient.Patch(): unexpected status 403 with OData
│ error: Authorization_RequestDenied: Insufficient privileges to complete the
│ operation.

TODO
may need to handle this: https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/guides/microsoft-graph#behaviour-change-default-user_impersonation-scope-for-applications
api {
oauth2_permission_scope {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant