Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions are sometimes missed #41

Open
mboynes opened this issue Mar 17, 2018 · 1 comment
Open

Revisions are sometimes missed #41

mboynes opened this issue Mar 17, 2018 · 1 comment

Comments

@mboynes
Copy link

mboynes commented Mar 17, 2018

Sometimes when previewing changes, neither wp_creating_autosave nor wp_before_creating_autosave fires, and thus the meta isn't saved to the revision. I believe it has something to do with timing; possibly that revisions aren't stored until WP has sent its first 'autosave' heartbeat. I haven't dug into the WP code yet to determine why that is. See demo below:

revisions

(Note, this is with #40 merged, so that meta previews work)

@adamsilverstein
Copy link
Owner

Right @mboynes the meta is only saved when the autosave fires. Possibly we can improve the logic of how this happens - any chance you can retest this in Gutenberg to see if its still an Issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants