Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version #509

Closed
fzalkow opened this issue Mar 6, 2023 · 1 comment · Fixed by #510
Closed

Python version #509

fzalkow opened this issue Mar 6, 2023 · 1 comment · Fixed by #510
Assignees
Labels
bug Something isn't working

Comments

@fzalkow
Copy link

fzalkow commented Mar 6, 2023

Hi,

The readme file specifies "Python 3.7+" as a requirement, which I understand as ">=3.7". However, the assignment operator := is used in the file adapters/utils.py, which is not allowed until Python 3.8.

Thanks for the great work with adapter-transformers!

@fzalkow fzalkow added the bug Something isn't working label Mar 6, 2023
@calpt calpt linked a pull request Mar 16, 2023 that will close this issue
@lenglaender
Copy link
Member

@fzalkow from now on we will officially only support python3.8+ as python3.7 is only supported until June this year. Nevertheless, the master branch should currently be fully functional with python3.7, but we cannot say how long this will be the case.

Thanks for letting us know that adapter-transformers no longer worked with Python 3.7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants