Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Use core mobileInstruction #302

Closed
swashbuck opened this issue May 29, 2024 · 2 comments
Closed

Migration: Use core mobileInstruction #302

swashbuck opened this issue May 29, 2024 · 2 comments

Comments

@swashbuck
Copy link
Contributor

swashbuck commented May 29, 2024

Subject of the enhancement

In this core PR, the mobileBody and mobileInstruction properties will be added to the core header template. The same mobileInstruction property specific to this plugin should be removed. However, migration scripts will be needed so that we do not break existing builds.

Dependencies

@oliverfoster
Copy link
Member

oliverfoster commented Jun 4, 2024

I don't understand what this issue is describing.

The mobileInstruction behaviour is in core and then utilised by this plugin when it sets a property value. I don't believe there is any code in this plugin which manages mobileInstruction except the schema and example.json.

The core pr adaptlearning/adapt-contrib-core#539 does not add inherited properties to the schema and it doesn't modify mobileInstruction which was there for this component to use already.

@swashbuck
Copy link
Contributor Author

Ok, yep, makes sense. Will close this ticket.

@swashbuck swashbuck closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@github-project-automation github-project-automation bot moved this from New to Recently Released in adapt_framework: The TODO Board Jun 4, 2024
@joe-allen-89 joe-allen-89 moved this to Recently Released in adapt_framework: The TODO Board Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants