Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking doesn't take into account availability of children #1373

Closed
tomgreenfield opened this issue Jan 9, 2017 · 2 comments
Closed

Locking doesn't take into account availability of children #1373

tomgreenfield opened this issue Jan 9, 2017 · 2 comments
Assignees
@tomgreenfield

Comments

@tomgreenfield
Copy link
Contributor

In adaptModel.js, the locking functionality doen't check for "_isAvailable": true when setting _isLocked.

Would be useful to include a new function getAvailableChildren() since a collection is already requested in three other places in the file.
@tomgreenfield tomgreenfield self-assigned this Jan 9, 2017
@oliverfoster
Copy link
Member

+1

@tomgreenfield tomgreenfield mentioned this issue Jan 9, 2017
Merged
@moloko
Copy link
Contributor

moloko commented Jan 11, 2017

done in 2f43c2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomgreenfield tomgreenfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomgreenfield @moloko @oliverfoster