Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt minifies course and config json unintentionally in two tasks #1461

Closed
oliverfoster opened this issue Mar 10, 2017 · 3 comments
Closed
Assignees

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 10, 2017

create-json-config and schema-defaults both inadvertently strip the whitespace from the course.json and config.json files making them unreadable.

https://github.com/adaptlearning/adapt_framework/blob/master/grunt/tasks/create-json-config.js#L37
https://github.com/adaptlearning/adapt_framework/blob/master/grunt/tasks/schema-defaults.js#L66

vs

https://github.com/adaptlearning/adapt_framework/blob/master/grunt/tasks/tracking-insert.js#L48-L49

This, rather irritatingly means that I can't read the json of the course or config files, but I can for articles, blocks and components.

@tomgreenfield
Copy link
Contributor

I'd +1 for minifying them all. I've had many cases in the past where I was mistakely editing the build files instead of src.

@oliverfoster
Copy link
Member Author

oliverfoster commented Mar 10, 2017

I think we should have a separate task off the back of the "build" task collection to do that and not do it in these tasks. Called "minify-json" or something of the sort. Period.

@moloko
Copy link
Contributor

moloko commented Mar 27, 2017

done in 020ceb5

@moloko moloko closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants