Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _classes to Notify 'push' #1496

Closed
brian-learningpool opened this issue Mar 31, 2017 · 1 comment
Closed

Add _classes to Notify 'push' #1496

brian-learningpool opened this issue Mar 31, 2017 · 1 comment
Assignees
@brian-learningpool
Labels
enhancement

Comments

@brian-learningpool
Copy link
Member

The Handlebars template is missing the {{_classes}} property which the standard Notify has, see https://github.com/adaptlearning/adapt_framework/blob/master/src/core/templates/notify.hbs#L1.

Adding this would allow more control over the styling of notify:push.
@brian-learningpool brian-learningpool self-assigned this Mar 31, 2017
@moloko
Copy link
Contributor

moloko commented Mar 31, 2017

done in fca05d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-learningpool brian-learningpool

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @brian-learningpool