Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework & adapt-contrib-vanilla - visual bug with questions with marking but no feedback #2627

Closed
guywillis opened this issue Jan 14, 2020 · 1 comment
Closed

Framework & adapt-contrib-vanilla - visual bug with questions with marking but no feedback #2627

guywillis opened this issue Jan 14, 2020 · 1 comment

Comments

@guywillis
Copy link
Contributor

Subject of the issue/enhancement/features

There is a visual bug with question components which have _canShowMarking: true alongside _canShowFeedback: false. This causes the marking icon to appear over the submit button and look visually incorrect.

screen-1

Your environment

  • v5 Framework

Expected behaviour

Marking icon does not appear over the submit / show correct answer button. The solution I propose would introduce margin on the submit button when _canShowMarking is enabled but _canShowFeedback is disabled.

screen-2

screen-3
This was referenced Jan 14, 2020
Merged
Merged
@guywillis
Copy link
Contributor Author

Resolved

@guywillis guywillis mentioned this issue Jan 20, 2020
Closed
7 tasks
@guywillis guywillis mentioned this issue Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guywillis