Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslib not found #2642

Closed
oliverfoster opened this issue Feb 10, 2020 · 6 comments
Closed

tslib not found #2642

oliverfoster opened this issue Feb 10, 2020 · 6 comments

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Feb 10, 2020

Subject of the issue

Current framework isn't compiling LESS properly due to upstream bug with less 3.11.0

less/less.js#3469

image

Confirmed working with 3.10.3

@brian-learningpool
Copy link
Member

In the meantime should the less version in package.json be set to 3.10.3 exactly? We should probably consider using package.lock going forward

@oliverfoster
Copy link
Member Author

oliverfoster commented Feb 10, 2020

Seems like a sensible suggestion.
A package-lock might fix both issues.

References:

@oliverfoster
Copy link
Member Author

The above PR is only going to work with master atm and the package-lock will need to be remade after every version number change just before release.

@moloko
Copy link
Contributor

moloko commented Feb 10, 2020

@oliverfoster that second link should be https://docs.npmjs.com/configuring-npm/package-lock-json.html I think

@moloko
Copy link
Contributor

moloko commented Feb 10, 2020

the package-lock will need to be remade after every version number change just before release

How's that done?

@oliverfoster
Copy link
Member Author

oliverfoster commented Feb 17, 2020

$ npm install --package-lock-only will ensure the lock file reflects the installed packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants