New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt-contrib-spoor: android chrome zoom not working #2800

Closed

oliverfoster opened this issue Jun 17, 2020 · 3 comments

Labels

bug good first bug

Member

oliverfoster commented Jun 17, 2020

Subject of the issue

Need to remove the maximum-scale value from the viewport meta-tag throughout:
https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/required/index.html#L11
https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/required/index_lms.html#L7
https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/required/scorm_test_harness.html#L8

Reference: #2569

oliverfoster added bug good first bug labels

Contributor

moloko commented Jun 17, 2020

derp, my bad for forgetting to amend these as well!

Member

NayanKhedkar commented Jun 17, 2020

😄
Pr: adaptlearning/adapt-contrib-spoor#196

Member Author

oliverfoster commented Jun 17, 2020

There's a secondary issue I'll do in a second. Scroll disable blocks zooming on notify and drawer fixed position elements.

oliverfoster mentioned this issue

issue/2800 Enabled zoom on fixed position popup elements with scroll disabled #2801

Merged

NayanKhedkar mentioned this issue

Removed max-scale from meta tag adaptlearning/adapt-contrib-spoor#196

Merged

oliverfoster closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment