Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer build vs final build request #2836

Closed
robertmausser opened this issue Jul 16, 2020 · 1 comment
Closed

Developer build vs final build request #2836

robertmausser opened this issue Jul 16, 2020 · 1 comment

Comments

@robertmausser
Copy link

Subject of the issue/enhancement/features

We use both Dev-Tools extension and Shadow-ID's extension to speed up development process of the framework

https://github.com/cgkineo/adapt-devtools

https://github.com/darylhedley/adapt-shadowIds

However every so often someone makes the mistake of not turning them off for the final build, which is obviously not a good thing!

Is there a way to have a line of code in JS or something that says "only build this if grunt dev command is used, not grunt build" So when we are working on the framework with the Grunt Dev command, they show up, but on final build with Grunt Build they dont?

Any other similar method or solution is greatly appreciated, this is just how I would forsee it working. If you have a different idea that works too, im all ears

Thank you!!!

Your environment

Adapt framework 4.4.0 and 5.0.

Browsers etc irrelevant

Steps to reproduce

Not an issue, feature request.

Expected behaviour

When the developer user Grunt Dev, devtools is available. When using Grunt Build, devtools is removed for final build.

Actual behaviour

Devtools is enabled even at build, causing learners to complete the course by using the devtools.

Screenshots (if you can)

@olivermartinfoster
Copy link
Contributor

olivermartinfoster commented Jul 22, 2020

With the latest framework master you can now do this:

config.json

    "build": {
        "productionExcludes": [
            "adapt-devtools"
        ]
    },

This will be listed in the next release as a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants