Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox - Triggering a Notify popup causes sudden page jump #2886

Closed
joe-replin opened this issue Aug 19, 2020 · 4 comments · Fixed by #2889
Closed

Firefox - Triggering a Notify popup causes sudden page jump #2886

joe-replin opened this issue Aug 19, 2020 · 4 comments · Fixed by #2889

Comments

@joe-replin
Copy link
Contributor

Using a fresh v5.6.1 Adapt install, triggering a notify panel causes a sudden jump to the top of the page. This happens with both presentation & question components.

Your environment

  • Adapt Framework - v5.6.1
  • Only present in Mozilla Firefox v79
  • Dell Inspiron + Windows 10

Screen Shot 2020-08-19 at 15 47 30

@oliverfoster
Copy link
Member

@joe-replin could you try out the above pr please?

@joe-replin
Copy link
Contributor Author

Thank you, @oliverfoster for pushing this as well as for the reference links. I have tested in 2 separate projects and Firefox is not misinterpreting that focus change anymore.

@oliverfoster
Copy link
Member

Could you accept the changes in the pr? @joe-replin
Or add a +1 if you don't have access to the "review changes" button on the "files changed" tab.
https://github.com/adaptlearning/adapt_framework/pull/2889/files

@oliverfoster oliverfoster reopened this Aug 20, 2020
@oliverfoster
Copy link
Member

Will get closed when the pr goes through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants