Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt_framework: router _canNavigate false state bug #3061

Closed
oliverfoster opened this issue Mar 10, 2021 · 0 comments · Fixed by #3063
Closed

adapt_framework: router _canNavigate false state bug #3061

oliverfoster opened this issue Mar 10, 2021 · 0 comments · Fixed by #3063
Assignees
Labels

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 10, 2021

Subject of the issue

When routing is prevented using router.set('_canNavigate', false) on router:navigate after calling router.navigateBack, a history record always gets dropped and should be re-added to return the history to its proper state.

Currently the router calls router.navigateToCurrentRoute which replaces the previous record rather than re-adding the current one.

When navigation is otherwise prevented, the history should always be moved back one to the proper state.

Essentially, if routing is prevented, the router needs to know if it has moved backwards to then go forward one or if it was going forward to then go backward one.

@oliverfoster oliverfoster self-assigned this Mar 10, 2021
@oliverfoster oliverfoster changed the title adapt_framework: router.navigateToCurrentRoute needs replace option adapt_framework: router _canNavigate false state bug Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant