You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When routing is prevented using router.set('_canNavigate', false) on router:navigate after calling router.navigateBack, a history record always gets dropped and should be re-added to return the history to its proper state.
Currently the router calls router.navigateToCurrentRoute which replaces the previous record rather than re-adding the current one.
When navigation is otherwise prevented, the history should always be moved back one to the proper state.
Essentially, if routing is prevented, the router needs to know if it has moved backwards to then go forward one or if it was going forward to then go backward one.
The text was updated successfully, but these errors were encountered:
oliverfoster
changed the title
adapt_framework: router.navigateToCurrentRoute needs replace option
adapt_framework: router _canNavigate false state bug
Mar 10, 2021
Subject of the issue
When routing is prevented using
router.set('_canNavigate', false)
onrouter:navigate
after callingrouter.navigateBack
, a history record always gets dropped and should be re-added to return the history to its proper state.Currently the router calls
router.navigateToCurrentRoute
which replaces the previous record rather than re-adding the current one.When navigation is otherwise prevented, the history should always be moved back one to the proper state.
Essentially, if routing is prevented, the router needs to know if it has moved backwards to then go forward one or if it was going forward to then go backward one.
The text was updated successfully, but these errors were encountered: