Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer animation duration can't be set to 0 #3108

Closed
simondate opened this issue Apr 1, 2021 · 1 comment · Fixed by #3109
Closed

Drawer animation duration can't be set to 0 #3108

simondate opened this issue Apr 1, 2021 · 1 comment · Fixed by #3109
Assignees
@moloko

Comments

@simondate
Copy link
Member

Subject of the issue/enhancement/features

If you set Adapt.config._drawer._duration to 0 it reverts back to using 400. I'm not sure if it's intentional but it's caused by this conditional assignment here.

Your environment

  • version (AT/Framework) Latest FW
@moloko
Copy link
Contributor

moloko commented Apr 1, 2021

should be able to fix this via use of nullish coalescing operator I think?

@moloko moloko self-assigned this Apr 1, 2021
@moloko moloko mentioned this issue Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow drawerDuration to be 0 adaptlearning/adapt_framework
2 participants
@moloko @simondate