Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete cascade in wrong order #927

Closed
oliverfoster opened this issue Jan 31, 2016 · 1 comment
Closed

complete cascade in wrong order #927

oliverfoster opened this issue Jan 31, 2016 · 1 comment
Assignees
Milestone

Comments

@oliverfoster
Copy link
Member

currently when a component triggers a block completion event, and a block an article, an article a page etc, the change events call back in the wrong order as the final parent relinquishes control of its change:_isComplete handler before the triggering element does.

So if a component completes, causing it's block to complete, causing it's article to complete and you're listening to the complete events, you'll get:

article completed
block completed
component completed

it should be:

component completed
block completed
article completed

@oliverfoster
Copy link
Member Author

#835 point 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants