Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-contrib-text: Change inview logic to OR rather than AND #944

Closed
brian-learningpool opened this issue Feb 15, 2016 · 1 comment
Closed

Comments

@brian-learningpool
Copy link
Member

I've noticed a very intermittent issue that I think may be related to timings in the inview code and very short text text components whereby the component wasn't completing when it should be. As such I'm proposing that we convert the inview check to use an OR rather than an AND.

@moloko
Copy link
Contributor

moloko commented Feb 29, 2016

should be fixed by inview update

@moloko moloko closed this as completed Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants