From 75bf8a9db9e6005c6b5a5beb086a9def6e1c1b76 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 17 Jul 2017 06:40:19 +0200 Subject: [PATCH] test: add DISABLED_ prefix to commented out test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 95ab966a742d23d7271c7b4c36fb84aa2bbece59 ("test: disable MultipleEnvironmentsPerIsolate") commented out MultipleEnvironmentsPerIsolate but it migth be better to disable the test so that this gets reported and not forgotten: YOU HAVE 1 DISABLED TEST PR-URL: https://github.com/nodejs/node/pull/14317 Reviewed-By: Gibson Fahnestock Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Tobias Nießen --- test/cctest/test_environment.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc index d116b4d995b8b7..db08743261c843 100644 --- a/test/cctest/test_environment.cc +++ b/test/cctest/test_environment.cc @@ -85,8 +85,7 @@ TEST_F(EnvironmentTest, AtExitWithArgument) { EXPECT_EQ(arg, cb_1_arg); } -/* -TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) { +TEST_F(EnvironmentTest, DISABLED_MultipleEnvironmentsPerIsolate) { const v8::HandleScope handle_scope(isolate_); const Argv argv; Env env1 {handle_scope, isolate_, argv}; @@ -101,7 +100,6 @@ TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) { RunAtExit(*env2); EXPECT_TRUE(called_cb_2); } -*/ static void at_exit_callback1(void* arg) { called_cb_1 = true;