-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fullcalendar source is obsolete #3
Comments
I will look into upgrading the JS/CSS source. Stripping all of the JS/CSS from the bundle would defeat the purpose of it. The goal is to get the calendar up and running for users with minimal configuration. Users are free to implement their own JS/CSS solution as they see fit. Additionally, fullcalendar does not appear to be available via composer, so this gives users easy access to it. Hopefully as this bundle gains more traction, users can help keep the source up-to-date. Thoughts? |
I disagree: putting an external library in your bundle is a bad practice, since you're forced to update your code every time external library is updated. |
Add the following to your composer.json to grab fullcalendar:
|
http://symfony.com/doc/master/cookbook/bundles/best_practices.html#vendors "A bundle should not embed third-party libraries written in JavaScript, CSS, or any other language." |
Current available version is 1.6.1, see http://arshaw.com/fullcalendar/download/
Maybe it would be a good idea to strip any Javascript/CSS source from bundle, while adding instructions on how to retrieve it from original websites
The text was updated successfully, but these errors were encountered: