Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullcalendar source is obsolete #3

Open
garak opened this issue May 14, 2013 · 4 comments
Open

fullcalendar source is obsolete #3

garak opened this issue May 14, 2013 · 4 comments

Comments

@garak
Copy link

garak commented May 14, 2013

Current available version is 1.6.1, see http://arshaw.com/fullcalendar/download/
Maybe it would be a good idea to strip any Javascript/CSS source from bundle, while adding instructions on how to retrieve it from original websites

@mikeyudin
Copy link
Member

I will look into upgrading the JS/CSS source. Stripping all of the JS/CSS from the bundle would defeat the purpose of it. The goal is to get the calendar up and running for users with minimal configuration. Users are free to implement their own JS/CSS solution as they see fit.

Additionally, fullcalendar does not appear to be available via composer, so this gives users easy access to it. Hopefully as this bundle gains more traction, users can help keep the source up-to-date.

Thoughts?

@garak
Copy link
Author

garak commented May 16, 2013

I disagree: putting an external library in your bundle is a bad practice, since you're forced to update your code every time external library is updated.
Best thing you could do is using a CDN for javascript and css. Unfortunately, full calendar seems not be available ad CDN resource (maybe you can open an issue with its author, or provide a CDN yourself). But please, at least strip out jQuery.
And, as I already mentioned, just add a small doc to let users of your bundle be able to retrieve js/css libraries.

@nurikabe
Copy link
Contributor

nurikabe commented Jun 7, 2013

Add the following to your composer.json to grab fullcalendar:

"repositories": [
        {
            "type": "package",
            "package": {
                "name": "arshaw/fullcalendar",
                "version": "1.6.1",
                "dist": {
                    "type": "zip",
                    "url": "http://arshaw.com/fullcalendar/downloads/fullcalendar-1.6.1.zip"
                }
            }
        },
        ...
"require": {
        ...
        "arshaw/fullcalendar": "1.6.1",

@garak
Copy link
Author

garak commented Jun 10, 2013

http://symfony.com/doc/master/cookbook/bundles/best_practices.html#vendors "A bundle should not embed third-party libraries written in JavaScript, CSS, or any other language."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants