Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra-apps): bump nginx-ingress to 0.34.* #288

Merged
merged 1 commit into from
Jun 28, 2021
Merged

fix(infra-apps): bump nginx-ingress to 0.34.* #288

merged 1 commit into from
Jun 28, 2021

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Jun 25, 2021

Description

bump nginx-ingress chart to 0.34.*:

Issues

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run -a
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

- Add namespace field in the namespace scoped resource templates
@hairmare hairmare marked this pull request as ready for review June 25, 2021 16:42
@hairmare hairmare requested a review from a team as a code owner June 25, 2021 16:42
@hairmare hairmare requested review from eyenx and vmaillot and removed request for a team June 25, 2021 16:42
Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only a patchfix bump?

@hairmare
Copy link
Contributor Author

hairmare commented Jun 28, 2021

Why only a patchfix bump?

because the upstream change is a patch and not a feature

by adding namespace fields to all the resources upstream is really only fixing a extremely specific issue with gitlab managed deployments based on running helm template

@eyenx
Copy link
Member

eyenx commented Jun 28, 2021

Well the upstream version change is from 0.33.x to 0.34.x tho... and not onlly a patchfix. Did they do it wrong?

@hairmare
Copy link
Contributor Author

hairmare commented Jun 28, 2021

Well the upstream version change is from 0.33.x to 0.34.x tho... and not onlly a patchfix. Did they do it wrong?

They are still on 0.y.z for initial development which is described as follows in the SemVer spec:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

@hairmare hairmare merged commit f55f3cb into adfinis:master Jun 28, 2021
@hairmare hairmare deleted the chore/bump-nginx-ingress branch June 28, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants