Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera_models.txt doesn't have proper directory matching structure #69

Closed
Jonseed opened this issue Nov 19, 2022 · 2 comments
Closed

camera_models.txt doesn't have proper directory matching structure #69

Jonseed opened this issue Nov 19, 2022 · 2 comments

Comments

@Jonseed
Copy link

Jonseed commented Nov 19, 2022

Describe the bug
The lines in camera_models.txt don't match the directory matching structure. For example:

__camera_models_acer__
__camera_models_agfaphoto__
__camera_models_benq__
__camera_models_canon__
__camera_models_casio__
__camera_models_concord__

Shouldn't these be:

__camera_models/acer__
__camera_models/agfaphoto__
__camera_models/benq__
__camera_models/canon__
__camera_models/casio__
__camera_models/concord__

Version used
c7434e7

To Reproduce
Steps to reproduce the behaviour, include the prompt you used if applicable:

  1. When you use camera_models it doesn't work correctly, and shows errors in the terminal that the models can't be found.

Also mention which checkboxes have been set.

Expected behaviour
Using the forward slash after camera_models in the txt file allows the script to find the models in the subdirectory.

Additional context
Unless I'm not using it right...

@adieyal
Copy link
Owner

adieyal commented Nov 20, 2022

Thanks for that - just uploaded a fix

@Jonseed
Copy link
Author

Jonseed commented Nov 21, 2022

Same thing with photographers.txt. Doesn't it need to have by_country/ before each country name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants