Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink Void binding in java. #56

Closed
timbod7 opened this issue Oct 20, 2017 · 3 comments
Closed

Rethink Void binding in java. #56

timbod7 opened this issue Oct 20, 2017 · 3 comments
Milestone
Release 1.0

Comments

@timbod7
Copy link
Collaborator

timbod7 commented Oct 20, 2017

Void is the ADL unit type, which in java we map to the Void type.

In java there are no instances of Void other than null. So we use null, but this breaks of of the null checks in the generated struct and union code.
@timbod7 timbod7 changed the title Rethink Void implementation in java. Rethink Void binding in java. Oct 20, 2017
@timbod7
Copy link
Collaborator Author

timbod7 commented Oct 27, 2017

Actually, it's not just a problem for Void - it will also happen for Nullable.

Perhaps in java, generic parameters shouldn't do null checks.

@timbod7
Copy link
Collaborator Author

timbod7 commented Oct 27, 2017

Actually no , it is only problem for Void - Nullable in ADL maps to Java Optional

@timbod7 timbod7 mentioned this issue Jul 15, 2020
Open
5 tasks
@timbod7 timbod7 added this to the Release 1.0 milestone Nov 17, 2020
@timbod7
Copy link
Collaborator Author

timbod7 commented Jan 29, 2021

Resolved with: 974e2e7

@timbod7 timbod7 closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.0
Development

No branches or pull requests
1 participant
@timbod7