Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation - install-lint.sh #521

Open
fmontedoridevlo opened this issue Aug 8, 2024 · 1 comment
Open

Installation - install-lint.sh #521

fmontedoridevlo opened this issue Aug 8, 2024 · 1 comment

Comments

@fmontedoridevlo
Copy link

I am trying to to follow the installation guide on the wiki page, however these information are not clear:

image

as if i try, just after cloning the repo, to run the point "3. sudo bash ./install-lint.sh" it says that it cannot find the file in the repo (as the file is not there).

@mmccawley-chegg
Copy link

mmccawley-chegg commented Sep 18, 2024

I took some notes to help the next person who comes across this (or in case the dev wants to update it).

  • As mentioned, install-lint.sh does not exist in the repo. Unless it gets added later, this should be skipped.
  • cd ADL_LRS/docker would be cd docker except that everything is run from the root directory. It should be omitted entirely.
  • install-reqs assumes a Debian based Linux system. There are some other minor issues even then such as installing curl twice instead of git and mixing apt with apt-get, but I would replace this with a check that they exist instead.
  • init-ssl.sh localhost should not be run with sudo. It should probably also check for an argument or fail without one.
  • docker-compose should be updated to docker compose and removed from install-reqs.sh if it is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants