Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests for empty statement arrays #274

Open
kelvinqian00 opened this issue Aug 30, 2024 · 2 comments
Open

No tests for empty statement arrays #274

kelvinqian00 opened this issue Aug 30, 2024 · 2 comments

Comments

@kelvinqian00
Copy link

An edge case that was noticed that is not covered in the conformance test suite (as of version 1.0.3) is that of empty statement arrays. There are no tests for POSTing empty statement arrays, nor are there any for GET requests after such a POST. The xAPI spec implies that these empty statement array insertions are actually valid, as it is not one of the cases explicitly mentioned as invalid in the spec, so there should be an additional test case to assert that POSTing empty statement arrays is valid.

While this does fall under #254 (as there are no tests for statement arrays in general), it is a distinct enough edge case that I believe warrants its own issue.

@vbhayden
Copy link
Member

vbhayden commented Oct 8, 2024

Hmm just now seeing this, good eye @kelvinqian00.

I'm not entirely sure what the test would look like though, as the specifics aren't stated anywhere as you mentioned. I am gonna defer to @andyjohnson on this one.

@kelvinqian00
Copy link
Author

Hi @vbhayden,

I imagine such a test would be similar to the statement array tests PR #255, however where that PR tests 1 and 2-item arrays, this test case would test when an array of length zero is inserted into the LRS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants