Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test archetypes in Eclipse before release #368

Closed
timdonovanuk opened this issue Apr 9, 2020 · 7 comments
Closed

Test archetypes in Eclipse before release #368

timdonovanuk opened this issue Apr 9, 2020 · 7 comments
Labels
task Task that needs doing.

Comments

@timdonovanuk
Copy link

This is a feature request to please ensure archetype compatibility with Eclipse + AEM plugin before release. The archetype is supposed to be a springboard for developers (particularly new ones), but it never seems to be a smooth process. Every release seems brings new problems, and requires lots of pom hacking and Googling to ensure an error free project.

As an example, the latest archetype (23):

I know end to end testing of everything is not possible, but it would be nice if the default path of Eclipse -> New AEM project always worked without half a dozen errors and warnings.

Thank you!

@timdonovanuk
Copy link
Author

And a picture being worth a thousand words, this is what a new developer will see after using the latest archetype in Eclipse to create a fresh project:

2020-04-09 14_37_02-Window

@timdonovanuk
Copy link
Author

Oh and one other thing...the project should actually build without errors too! If you were unfortunate enough to specify frontendModule=general you'll find your shiney new project doesn't actually mvn clean install:

[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project org.foo:foo:0.0.1-SNAPSHOT (C:\eclipse-workspace-2\foo\pom.xml) has 1 error
[ERROR] Child module C:\eclipse-workspace-2\foo\ui.frontend of C:\eclipse-workspace-2\foo\pom.xml does not exist

and requires commenting out the frontend modules in the root pom.xml.

@timdonovanuk
Copy link
Author

And if you tick the publish to server box, you'll get yet another error...

Publishing failed
Failed installing bundle : Manifest does not have a Bundle-SymbolicName
Manifest does not have a Bundle-SymbolicName
Failed publishing path=/conf/foo/settings/wcm/policies/rep:policy, result=JcrResult[ success:false, exception: org.apache.sling.ide.transport.RepositoryException - javax.jcr.nodetype.ConstraintViolationException: {internal}policy is protected.]

@timdonovanuk
Copy link
Author

And if you try building from the command line you get....

[INFO] Scanning for projects...
[ERROR] [ERROR] Project 'org.foo:foo.ui.frontend:0.0.1-SNAPSHOT' is duplicated in the reactor @
[ERROR] Project 'org.foo:foo.ui.frontend:0.0.1-SNAPSHOT' is duplicated in the reactor -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DuplicateProjectException

@gabrielwalt gabrielwalt added this to the 24 milestone Aug 28, 2020
@gabrielwalt gabrielwalt added the task Task that needs doing. label Aug 31, 2020
@msagolj
Copy link
Contributor

msagolj commented Sep 10, 2020

  • verified that the project builds without errors
  • verified that the project does not throw anymore filevault-package-maven-plugin warnings
  • verified that the generated project can be imported in eclipse (there are still some eclipse specific warnings that require changes in eclipse settings but are unrelated to the archetype project itself )
  • Due to the changed groupId the released archetype 24 will not be found/selectable in the eclipse AEM plugin tool. This requires a new release of the AEM plugin tool

@msagolj msagolj modified the milestones: 24, Future Sep 10, 2020
@msagolj
Copy link
Contributor

msagolj commented Sep 16, 2020

Corresponding issue in developer tools: adobe/aem-eclipse-developer-tools#91

@gabrielwalt
Copy link
Member

Closing this issue as it's more of a task that impacts the Eclipse plugin than the Archetype

@gabrielwalt gabrielwalt removed this from the Future milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task that needs doing.
Projects
None yet
Development

No branches or pull requests

3 participants