Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Dialog label same for Quick Open, Go to Line and Go to Definition #1705

Closed
sagarsane opened this issue Sep 23, 2012 · 4 comments
Closed

Dialog label same for Quick Open, Go to Line and Go to Definition #1705

sagarsane opened this issue Sep 23, 2012 · 4 comments
Assignees
@njx
Labels
fixed but not closed low priority
Milestone
sprint 18

Comments

@sagarsane
Copy link
Contributor

Hello,

In search/QuickOpen.js,

the dialogHTML has Strings.CMD_QUICK_OPEN as the label. Should it have a switch case around it and display appropriate Labels (from Strings.CMD_GOTO_LINE and Strings.CMD_GOTO_DEFINITION and Strings.CMD_QUICK_OPEN), based on the prefix ("", ":", "@") that is passed?

I will submit a quick pull request for this if it is okay.

Thanks.
Sagar
@sagarsane sagarsane mentioned this issue Sep 23, 2012
Closed
@pthiess
Copy link
Contributor

pthiess commented Sep 26, 2012

Reviewed - assigning to @njx

@ghost ghost assigned njx Sep 26, 2012
@peterflynn peterflynn mentioned this issue Nov 15, 2012
Closed
@njx njx mentioned this issue Dec 6, 2012
Merged
@njx
Copy link
Contributor

njx commented Dec 6, 2012

Note: I didn't add this to the "Sprint 18 Bugs" Trello card since it's already accounted for in the "Sprint 18 Pull Requests" card.

@njx
Copy link
Contributor

njx commented Dec 11, 2012

@sagarsane - we've merged your commits along with our additions. Could you verify this is fixed? Thanks!

@njx
Copy link
Contributor

njx commented Dec 19, 2012

Closing, confirmed it ourselves.

@njx njx closed this as completed Dec 19, 2012
@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@njx njx

Labels
fixed but not closed low priority
Projects
None yet
Milestone
sprint 18
Development

No branches or pull requests
3 participants
@sagarsane @njx @pthiess