Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up usePress code #1720

Open
devongovett opened this issue Mar 19, 2021 · 6 comments
Open

Clean up usePress code #1720

devongovett opened this issue Mar 19, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@devongovett
Copy link
Member

devongovett commented Mar 19, 2021

  1. We can probably get rid of the fallback events (mouse/touch) now since all supported browsers support pointer events. Is it me or react-aria have a larger bundle-size than similar libraries? #5636 (reply in thread) is why we can't get rid of the fall backs
  2. Clean up the various states to simplify the code.
  3. Possibly get rid of the custom hit testing. The code comment indicates that this was for iOS < 13.2 which is long gone, so possibly this isn't needed anymore. We will need to do some testing. Related: Press events are not dispatched correctly on iOS Chrome/Safari #1061 An attempt to fix onPress not being called when pressing near element boundaries #1613
@cpatti97100
Copy link

Hi all, is this being taken into consideration?

@snowystinger
Copy link
Member

Yes, however, it has some nuances that we'll need to account for, see #5636 (reply in thread)

feel free to make a PR for it

@nicosammito
Copy link

nicosammito commented Feb 13, 2024

Would be great if a fix is introduced

#5290

@LFDanLu
Copy link
Member

LFDanLu commented Mar 6, 2024

#2506 is related

@github-project-automation github-project-automation bot moved this to ✏️ To Groom in RSP Component Milestones Mar 6, 2024
@LFDanLu LFDanLu added the help wanted Extra attention is needed label Mar 6, 2024
@MrHBS
Copy link

MrHBS commented May 8, 2024

Please consider prioritizing this issue.

@freisenhauer
Copy link

Any updates on this ? This or rather the issue that buttons cannot be used by vimium is a real issue for me. This blocks my entire workflow.

@LFDanLu LFDanLu moved this from ✏️ To Groom to 📋 Waiting for Sprint in RSP Component Milestones Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: 📋 Waiting for Sprint
Development

No branches or pull requests

7 participants