feat: endpoint to handle fulfillment_completed events #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: stub in route and controller
WIP: Hoolihan event processing
WIP: pass context to controller to facilitate env var injection
Rework processor steps so that an error sending to SQS leads to an error response from the controller
Test coverage to 100%. Improve JSDocs
solaris007
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Great contribution, thank you @blefebvre ! I have just nitpick comments.
|
This PR will trigger a minor release when merged. |
Co-authored-by: Dominique Jäggi <[email protected]>
Co-authored-by: Dominique Jäggi <[email protected]>
|
Thank you @solaris007 for the review and suggestions. |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
POST /event/fulfillmentendpoint as detailed in the API spec.Provides a method to handle
fulfillment_completedevents from the Fulfillment Gateway. Events are queued for processing onto the provided SQS queue URL.A sample event in the expected format can be found in
test/controllers/event/sample-hoolihan-event.jsonTicket: https://jira.corp.adobe.com/browse/SITES-19428